New Design/Branding
Feedback related to current LodePay redesign spec communicated as a single epic. Feedback primarily based on the below artifacts and their sublinks/subtasks:
At a high level BCF suggests this saga be broken down further into the following high-level epics:
Rebrand the existing mobile wallet screens to ‘LodePay’ adding no new functionality whatsoever
Add the ‘members portal functionality’ to the rebranded LodePay Wallet in mobile-only form. At the end of this milestone there should be 1:1 feature parity between the desktop members portal and the LodePay app but all features are accessible in mobile-only form factor.
Implement Web Wallet by adding desktop-responsiveness to all application screens. In certain screen situations where the the design spec dictates an entirely-different design for the desktop context (rather than simple responsive design) such designs are implemented at this stage. The wallet will be accessible from a web browser from this stage as well but mobile-only functionality such as QR-code reading will be hidden from the user.
BCF suggests the milestones be tacked in 1, 2, 3 order but there is some ability to tweak that ordering.
FINAL:
General
Across the board we need a swagger doc that outlines the available APIs for retrieving data represented in the new designs that is housed within Lode’s cloud environment. In some cases the members portal API will need to perform additional actions behind the scenes in order to build the dataset that is needed to populate some of these new screens.
Example: Recent Activity
Need members portal to be adding ‘activity entries’ as user’s perform actions. In some cases the wallet (or related microservices) may need to call a specific endpoint on the members portal to register an activity; we need these APIs defined and documented
Activity types- we need to agree on a standard set of activity types and what the display entry for that activity type looks like. Currently we have a number of sample rows that relate to things like ‘direct payment’, ‘payment sent’ and some other un-titled activities. We need to finalize the list of these activities and what their display looks like.
Example: Buy > Purchase History
The VDC microservice has some ability to provide a purchase history relative to certain assets but would need to be enhanced to provide a ‘proper’ purchase history for those assets.
For other assets we would need new API’s for purchase history specifically things such as purchases of LODE tokens.
Example: Buy > Lode > Bank Wire
We don’t support this payment method at all in the wallet today so we will need documented APIs around the bank-wire purchase process.
Desktop designs have a navbar at the top with a ‘search’ field, what does this search across?
Designs for both desktop and mobile show users having an avatar but there is no way to set/upload an avatar, what should the expectation for avatars be?
There is also a notifications icon on the top bar but we have no designs of it ‘expanded'. What are the notifications expected in this area? Are they expected to persist in some way?
There is a ‘gift icon’ in the navbar, we aren’t sure what functionality is expected of this control.
Support - there is a nav item for support but no designs for a support page. What is the expectation when the user clicks this button?
Components
Need ‘loading component’ for
Full page loading (currently large circle loader in AGXPayMobile, visible on VDC screen and Gas Station screen)
Process pending (currently bottom-blue indeterminate loading bar presented when user is setting up a new wallet or restoring a backed-up wallet)
Dropdown design will require significant additional dev work to accommodate the custom ‘dropdown style’ shown in the mockup. Additionally this type of modification of the dropdown is non-standard for many modern applications.
Row component- we can use rows within lists as components (swipe left or right on the row to perform an action). We use this in the transaction-history view and need a design spec for it there (and can use it in other views JFYI for design team).
Feedback: Warning messages look very similar to buttons
Login
Design is not standard responsive
Where does the ‘Let’s get started' view show? The wallet setup step occurs before it making it unreachable
Desktop: Swipe picture to navigate slide set
Text overlaid on slide (and animated?)
Wallet-init controls displayed using button-panels to the right of the slides
Mobile: Swipe picture to navigate slide set
Text displayed as header/subheader at bottom of screen
Wallet-init controls displayed using standard buttons below the slides
Terms of Service
Desktop: Terms displayed to the right of the login-slides in self-contained scrolling panel. Should scroll independently of page. Agree/Disagree buttons should be visible at all times.
Mobile: Terms displayed to the right of the login-slides in self-contained scrolling panel. Should scroll independently of page. Agree/Disagree buttons should be visible at all times.
Agree button should be disabled until user scrolls to the bottom of the TOS
TOS should be fetched dynamically
Currently there are no requirements around logging the user’s agreement to the TOS (its simply flagged in local storage)
New Wallet - Display Recovery Phrase
Different component displays the phrase on desktop v. mobile
New Wallet - Reenter Recovery Phrase
Different component displays the phrase on desktop v. mobile
Progress bar?
Existing Wallet - Enter Recovery Phrase
Should we center align form on desktop to match all other center-aligned desktop forms?
Progress bar?
Create Wallet - Link Lode Account on Setup
Why use option buttons on desktop rather than making it match mobile?
Create Wallet - Link- New account
Not standard responsive design
Desktop: “skip this step” button- artifact that should be removed?
What happens after you create a new account?
You get an email with a confirmation code?
The email has a link to automatically confirm?
The app takes u to a page to enter the confirmation code?
What features should be disabled if the user signs up for a new account but hasn’t agreed to any of the investment contracts/TOS/etc outside of the initial TOS required in order to use the app to begin with.
Create Wallet - Link- New account enter confirmation code
details TBD
Create Wallet - Link - Existing Account
2FA code input needs to be its own screen/experience based on if that user has 2fa enabled.
Dashboard
different designs for mobile and desktop, not simple responsive
in desktop mode, a QR code ‘address’ is shown, address will be different based on coin, which address are we showing here?
Dashboard shows a total sum of all assets. What do we do for assets that do not have a fiatValue datasource?
On desktop for >5 assets will the list just scroll horizontally or can it only be navigated using the arrows in the top right?
Why show masked VDC in assets list view when nothing can be done with it? Also we are no longer showing the VDC balance in assets view?
Buy
Why show token info modal prior to purchase? This will become redundant very fast and annoy users.
Different designs for mobile v desktop, not standard responsive
Will purchase methods be hardcoded per-asset or will it be dynamic in some way?
Designs show purchase flow for ‘buy LODE tokens with Silvercard’ - how do the flows for buying LODE with Silver Bullion or with Bank Wire look?
When purchasing tokens with a silvercard there aren’t designs to for choosing whether you are buying a new card or whether you are redeeming an existing epin.
There is a design for 'Add an item to deliver in exchange for Lode Tokens) but it seems to be the start of some kind of shopping cart experience? Ne`ed more info on the rest of the flow here / what happens if the user leaves mid-flow, etc.
In mobile mode are the screens intended to be presented 1, 2, 3 sequentially or as-shown-in-design 1,2,3 one giant scrolling list that is dynamically updated as you perform actions in other areas of the screen?
What does the info icon in the top right of buy screens show?
Need an API for historical token price, in the case of LODE/AGX/AUX we would need the members portal to provide a special API for that data.
Assets
Nonstandard design for responsive layout
How is tx history display on desktop and mobile? Its unclear how a user chooses the asset they want to interact with on desktop.
Will need members portal APIs to support ‘merged’ transaction history as represented in the design which supports pagination/loading more.
On mobile what happens when you press the action buttons from the main list view (ie: send, receive, buy)
Need an API for historical token price, in the case of LODE/AGX/AUX we would need the members portal to provide a special API for that data.
Assets - Coin Page
Where is history price history drawn from (what API source?)
What should we do for assets that have no fiat value data source
Assuming that tx history should remain as-is today aka ‘load more’ etc.
Gas Station
Not standard responsive design
same components can be reused on desktop/mobile but layout and routes will be different (routes… maybe)
Should consider GAS station for ETH?
Settings - Unlinked - FOR ALL SETTINGS SCREENS WE NEED API DOCS
Unlinked view not standard responsive design (although simple)
Showing 2FA alongside U/P is nonstandard, it needs to be a secondary step after U/P has been authenticated
Settings - Signup
Signup form is same component but shown in modal on desktop (why?)
confirmation code sent via email- same component but modal on desktop (why?)
Settings - Linked - This view is strange in the mobile v. desktop sense very different control paradigms at play
Profile
Standard responsive form - special validators we need to know about?
Preferences
Why is this view so dramatically different on mobile? are elements missing from desktop?
Account Info - these views are very different between desktop and mobile, its very jarring.
Where is this on mobile?
Change password screen
Enhance rules UI
Things like recovery phrase, wallet pin are not related to your account they can exist without a lode account at all, these should likely be in a different tab altogether.
Pin change- modal on desktop, standard screen on mobile
Recovery phrase - modal on desktop, standard screen on mobile
Investment Contracts
different views for desktop v mobile (again, modal v standalone screen)
What are the expectations for the various investment contracts and storing the user accepted info?
What does ‘more information’ do in these views (desktop)?
Brad
Which token is this qr code for? I would remove this but if this part of the design is removed it will throw the whole design off.
Designs show Full transaction history for Virtual cards. There is no support for this on the VDC API’s.
Mockups show the use of avatars but in the designs there is no method of uploading an avatar. Will also need somewhere to store avatars.
There are three colours of transactions , red (cancelled), orange/yellow and green. “Cancelled” is not a thing in Syscoin land, but may be in Ethereum - we would need to build all the “Cancel” functionality avaiable in Metamask for cancelling a transaction.
the left/right “Send Again” and “Copy Address” functionality is missing.
"recent activity" will need to pull from various API’s including "new affiliate" and “news” as seen in mockups. Which APIs and which events to include should be defined and listed.
I see "Bitcoin Support" on an older design. Confirm this has been removed.
"Lode" token support? Are we supporting Hyperledger tokens?
Buying Lode tokens with "bank wire" this will definitely not be easy. Is there a service available? Will probably need an entire development cycle just for this.
An older design showed no option NOT to have a LODE account, but the new design shows optional? Prefer optional.
Phone number,as mandatory is invasive. Current community members who JUST want to use the wallet for SYS or ETH will be very unlikely to supply their phone number.
There's a whole "notifications" section via email so there will need to be an smtp service that is not blacklisted
Network switcher is not in the designs (but should be in test mockups)
How are we connecting to these additional services such as password change etc.
“Support” is not defined at all. Does this link to an external site?
This section is a bit confusing because which asset we are sending is only signified by a tiny dropdown menu. It would reduce errors by having the user choose the asset before displaying the “send” form.
This also has a link to gas station functionality which seems to be missing from designs. We may want to add that functionality for Ethereum (tokens) as well.
This (dashboard) might be a good place to highlight the heirarchy of Ethereum and Syscoin as master chains vs tokens (agx/aux/usdc etc)
Argenis
Not sure if
Show Recovery Phrase
andChange Wallet PIN
belong to this section. I think wallet-related stuff should go into its ownWallet
tab.2. Amounts in AGX?
3. Theres no
loading
state in any of the components or the views. No error state either
GDrive with all files:
https://drive.google.com/drive/folders/1bSTo1LnBusiyEzWWtMvnaUvMXQivXaYI
Dev considerations:
Would it be wise to create a new repo? Fork? Apps are too different
Keep angular-wallet-base strictly for wallet purposes. Even now there is stuff there that is AGXPay only. Might need to move some stuff before starting.
This means we'll have additional folders for services, reducers, actions, bla bla bla.
Found an article with considerations when creating an app that is meant to run in both mobile and browser:
https://ionicframework.com/blog/customizing-ionic-apps-for-web-mobile/
Dan
Button styles- there are no styles defined for the ‘click’ states of the new buttons, is that intentional?
For links does the hoer style make the font weight less? The seem less-visible on hover based on the components PDF
Affiliates Page
Design is non-standard for responsive
The mobile version of the ‘My Connections’ section doesn’t seem to communicate much in respect to each connection’s status as compared to the desktop view.
Need API documentation for members portal to ensure that it has the endpoints+responses required to facilitate the data rendered in this view and some of the functionality expressed in this view (such as paginated ‘My Connections’
Reward History
API docs and responses
does clicking on a reward take the user anywhere?
News
API docs and responses
Seems like mostly-standard responsive design
News Article
API docs and responses
confirm responsive mobile view simply drops right sidebar
ensure any HTML coming from API is properly sanitized (warn API dev team about this)
Support
We assume there will be an API for support questions and answers? Need API docs and responses
Seems like mostly standard responsive design
Dashboard
API docs and responses
different designs for mobile and desktop, not simple responsive
desktop version has new sections that will require need read and WRITE apis:
recent activity
in desktop mode, a QR code ‘address’ is shown, address will be different based on network, which address are we showing here?
Dashboard shows a total sum of all assets. What do we do for assets that do not have a fiatValue datasource?
On desktop for >5 assets will the list just scroll horizontally or can it only be navigated using the arrows in the top right?
Buy
Seems mostly standard responsive
Purchase history - Why different design for rows in desktop view vs. rows in mobile view
Need to create APIs to support purchase history
Buy Step 2 - select payment method
Different designs for mobile v desktop, not standard responsive
Will purchase methods be hardcoded per-asset or will it be dynamic in some way?
Designs show purchase flow for ‘buy LODE tokens with Silvercard’ - how do the flows for buying LODE with Silver Bullion or with Bank Wire look?
When purchasing tokens with a silvercard there aren’t designs to for choosing whether you are buying a new card or whether you are redeeming an existing epin.
There is a design for 'Add an item to deliver in exchange for Lode Tokens) but it seems to be the start of some kind of shopping card experience? Need more info on the rest of the flow here.
In mobile mode are the screens intended to be presented 1, 2, 3 sequentially or as-shown-in-design 1,2,3 one giant scrolling list that is dynamically updated as you perform actions in other areas of the screen?
VDC
Mostly standard responsive design with some exceptions
Why use modal for form on desktop? When buying silver forms are not wrapped in modals… #consistency
Recent activity related to VDC currently has no API support, no support for transaction history etc.
Assets
Nonstandard design for responsive layout
How is tx history display on desktop? Its unclear how a user chooses the asset they want to interact with on desktop.
On mobile what happens when you press the action buttons from the main list view (ie: send, receive, buy)
What is ‘recent activity’ on the main asset page mobile view drawn from?
Assets - Coin page
Where is history price history drawn from (what API source?)
What should we do for assets that have no fiat value data source
Gas Station
Not standard responsive design
same components can be reused on desktop/mobile but layout and routes will be different (routes… maybe)
Settings - Unlinked - FOR ALL SETTINGS SCREENS WE NEED API DOCS
Unlinked view not standard responsive design (although simple)
Settings - Signup
same component but shown in modal on desktop (why?)
confirmation code sent via email- same component but modal on desktop (why?)
Settings - Linked - This view is strange in the mobile v. desktop sense very different control paradigms at play
Profile
Standard responsive form - special validators we need to know about?
Preferences
Why is this view so dramatically different on mobile? are elements missing from desktop?
Account Info
Where is this on mobile?
Change password screen
Enhance rules UI
Pin change- modal on desktop, standard screen on mobile
Recovery phrase - modal on desktop, standard screen on mobile
Investment Contracts
different views for desktop v mobile (again, modal v standalone screen)
What are the expectations for the various investment contracts and storing the user accepted info?
What does ‘more information’ do in these views?